Skip to content

test: move test-vm-break-on-sigint to sequential #44140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Aug 7, 2022
Merged

test: move test-vm-break-on-sigint to sequential #44140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: move test-vm-break-on-sigint to sequential 
This PR moves `test-vm-break-on-sigint.js` to sequential, following the
other PRs I have made to move CPU intensive tests into sequential. The
test has already been tuned to do less iterations in a previous PR.
However it is still causing ~7% of build failures. The timeouts seem
highly correlated with other tests which spawn a bunch of threads also
failing, see for example the [first Jenkins failure][] and the [last
Jenkins failure][].

[first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
[last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/

Refs: #44090
Refs: #43981
Refs: nodejs/reliability#337
  • Loading branch information
@kvakil
kvakil committed Aug 5, 2022
commit 1eaa78b61de5b69264f40ce0eca07a7dfeb4b930
0 test/parallel/test-vm-break-on-sigint.js → test/sequential/test-vm-break-on-sigint.js
View file
Open in desktop
File renamed without changes.