Skip to content

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder #44104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Aug 4, 2022
Merged

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder #44104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder 
To improve startup performance.
  • Loading branch information
@joyeecheung
joyeecheung committed Aug 2, 2022
commit ef44fe7aaf1658c6755999f288fc1adc96d67ee2
2 changes: 1 addition & 1 deletion src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ int SnapshotBuilder::Generate(SnapshotData* out,

// Must be out of HandleScope
out->v8_snapshot_blob_data =
creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kClear);
creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kKeep);

// We must be able to rehash the blob when we restore it or otherwise
// the hash seed would be fixed by V8, introducing a vulnerability.
Expand Down