Skip to content

stream: update TextEncoderStream to align with the latest spec #44101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Aug 4, 2022
+66 −8
Merged

stream: update TextEncoderStream to align with the latest spec #44101

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebbf25f
stream: update TextEncoderStream to align the latest spec
cola119 Aug 3, 2022
c44d983
fixup! stream: update TextEncoderStream to align the latest spec
cola119 Aug 3, 2022
4a92843
fixup! stream: update TextEncoderStream to align the latest spec
cola119 Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! stream: update TextEncoderStream to align the latest spec
  • Loading branch information
@cola119
cola119 committed Aug 3, 2022
commit c44d983946d5c323e5c5275d8410cbfe2453c34d
3 changes: 2 additions & 1 deletion lib/internal/webstreams/encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const {
ObjectDefineProperties,
Symbol,
String,
StringPrototypeCharCodeAt,
Uint8Array,
} = primordials;

Expand Down Expand Up @@ -62,7 +63,7 @@ class TextEncoderStream {
let finalChunk = '';
for (let i = 0; i < chunk.length; i++) {
const item = chunk[i];
const codeUnit = item.charCodeAt(0);
const codeUnit = StringPrototypeCharCodeAt(item, 0);
if (this[kPendingHighSurrogate] !== null) {
const highSurrogate = this[kPendingHighSurrogate];
this[kPendingHighSurrogate] = null;
Expand Down