Skip to content

[v16.x backport] src: pass only Isolate* and env_vars to EnabledDebugList::Parse() #44070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 46 commits into from
Closed

[v16.x backport] src: pass only Isolate* and env_vars to EnabledDebugList::Parse() #44070

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
a7677bc
fs: use signed types for stat data
LiviaMedeiros Jul 18, 2022
b8e5873
src: use named struct instead of typedef
tniessen Jul 18, 2022
cc97a8d
meta: update AUTHORS
nodejs-github-bot Jul 18, 2022
822b9c3
util: add tokens to parseArgs
shadowspawn Jul 18, 2022
3933ce3
deps: update undici to 5.8.0
nodejs-github-bot Jul 18, 2022
d4a0d39
build: add .gitattributes for npm and other shims
hrishikesh-kadam Jul 19, 2022
a88e8e5
tools: update doc to highlight.js@11.6.0
nodejs-github-bot Jul 19, 2022
26c863d
test: ensure NODE_EXTRA_CA_CERTS not set before tests
KrayzeeKev Jul 20, 2022
5b253cc
doc: add security release specifics to releases.md
BethGriggs Jul 14, 2022
d6bc311
doc: mention Win 32-bit openssl build issue
RafaelGSS Jul 15, 2022
df9693d
tools: support versioned node shared libs on z/OS
alexcfyung Mar 8, 2022
bc376c9
tools: add support for using API key to vuln checking script
facutuesca Jul 20, 2022
212115c
child_process: do not need to count length when maxBuffer is Infinity
theanarkh Jul 21, 2022
07c8c4e
http: add drop request event for http server
theanarkh Jul 22, 2022
822fa99
tools: add verbose flag to inactive TSC finder
Trott Jul 22, 2022
e0a8a58
doc: add F3n67u to collaborators
F3n67u Jul 23, 2022
12da85a
doc: fix typo in http.md
airingursb Jul 23, 2022
fc872e5
deps: update hast-util-raw
MoLow Jul 23, 2022
d69b19b
test: simplify ReplStream.wait()
tniessen Jul 23, 2022
687b79a
dns: fix cares memory leak
theanarkh Jul 24, 2022
ad2da1f
dns: fix getServers return undefined
jiahao-si Jul 24, 2022
e297afb
cluster: send connection to other server when worker drop it
theanarkh Jul 24, 2022
a9ab465
stream: fix 0 transform hwm backpressure
ronag Jul 24, 2022
aff813f
util: remove unicode support todo for perf implications
Anemy Jul 24, 2022
34e2c9c
doc: remind backporter about v8_embedder_string
kvakil Jul 24, 2022
7e75216
process: use `defineProperty` instead of assignment
erights Jul 24, 2022
72995c0
meta: update `node-api` in label-pr-config
daeyeon Jul 24, 2022
0ed25c3
doc: fix typo in `src/crypto/README.md`
Jianru-Lin Jul 24, 2022
5cc7554
test: fix test http upload timeout
theanarkh Jul 24, 2022
95dbd86
deps: update corepack to 0.12.1
nodejs-github-bot Jul 24, 2022
ffecb8a
meta: update AUTHORS
nodejs-github-bot Jul 24, 2022
3c077ab
doc: clarify subprocess.stdout/in/err property
cola119 Jul 24, 2022
8339409
test: simplify test-tls-set-secure-context
tniessen Jul 24, 2022
75e60cb
test: work scheduled in process.nextTick can keep the event loop alive
andreubotella Jul 24, 2022
105453b
buffer: do not leak memory if buffer is too big
kvakil Jul 24, 2022
7acbe8f
trace_events: trace net connect event
theanarkh Jul 24, 2022
5e9bdb6
test: remove test-whatwg-events-add-event-listener-options-once.js
F3n67u Jul 24, 2022
e6048b0
inspector: set sampling interval before start
codebytere Jul 25, 2022
b957882
net: fix socket._getpeername
daeyeon Jul 25, 2022
24b4a59
doc: recommend git-node-v8
kvakil Jul 25, 2022
8744e6b
tools: add more options to track flaky tests
aduh95 Jul 25, 2022
122864f
doc: improve documentation for safe `Promise` statics alternatives
aduh95 Jul 25, 2022
7f33433
doc: inspector.close undefined in worker threads
kvakil Jul 16, 2022
23cab44
test: update WPT encoding tests
cola119 Jul 25, 2022
acc68c9
doc: update email and mailmap for BethGriggs
BethGriggs Jul 25, 2022
1073bee
src: pass only Isolate* and env_vars to EnabledDebugList::Parse()
RaisinTen Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: mention Win 32-bit openssl build issue 
PR-URL: #43853
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@RafaelGSS @targos
RafaelGSS authored and targos committed Jul 31, 2022
commit d6bc3117c63d936dd39b95a7a8dc984d3dba4beb
10 changes: 10 additions & 0 deletions doc/contributing/maintaining-openssl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ Use `make` to regenerate all platform dependent files in
% make -C deps/openssl/config
```

**Note**: If the 32-bit Windows is failing to compile run this workflow instead:

```console
% make -C deps/openssl/config clean
# Edit deps/openssl/openssl/crypto/perlasm/x86asm.pl changing
# #ifdef to %ifdef to make it compatible to nasm on 32-bit Windows.
# See: https://github.com/nodejs/node/pull/43603#issuecomment-1170670844
# Reference: https://github.com/openssl/openssl/issues/18459
```

## 3. Check diffs

Check diffs to ensure updates are right. Even if there are no updates in openssl
Expand Down