Skip to content

src: fix to use replacement character for unassigned codepoint #43999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 29, 2022
Merged

src: fix to use replacement character for unassigned codepoint #43999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
649c279
src: fix to use replacement character
cola119 Jul 26, 2022
30be3cd
fixup! src: fix to use replacement character
cola119 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: fix to use replacement character
  • Loading branch information
@cola119
cola119 committed Jul 27, 2022
commit 30be3cd21cd01c1f95b5d8827ecec10f45d70efa
2 changes: 1 addition & 1 deletion test/parallel/test-whatwg-encoding-custom-textdecoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ if (common.hasIntl) {
assert.strictEqual(str, 'foo\ufffd');
}

{
if (common.hasIntl) {
const decoder = new TextDecoder('Shift_JIS');
const chunk = new Uint8Array([-1]);
const str = decoder.decode(chunk);
Expand Down