Skip to content

worker: add flag to control old space size #43995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvakil wants to merge 3 commits into
base: main
Choose a base branch
from
Open

worker: add flag to control old space size #43995

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c14bbe
worker: add flag to control old space size
kvakil Jul 26, 2022
f1fdb84
fixup! worker: add flag to control old space size
kvakil Jul 26, 2022
61b6baa
fixup! worker: add flag to control old space size
kvakil Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! worker: add flag to control old space size
  • Loading branch information
@kvakil
kvakil committed Jul 26, 2022
commit f1fdb84e3ec20946317faae3c1f2c0d19b555e8a
2 changes: 1 addition & 1 deletion src/node_main_instance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ NodeMainInstance::NodeMainInstance(const SnapshotData* snapshot_data,
platform->RegisterIsolate(isolate_, event_loop);
SetIsolateCreateParamsForNode(isolate_params_.get());

size_t thread_max_old_space_size = options->thread_max_old_space_size;
size_t thread_max_old_space_size = static_cast<size_t>(options->thread_max_old_space_size);
if (thread_max_old_space_size != 0) {
isolate_params_->constraints.set_max_old_generation_size_in_bytes(
thread_max_old_space_size * 1024 * 1024);
Expand Down
2 changes: 1 addition & 1 deletion src/node_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class PerIsolateOptions : public Options {
bool report_uncaught_exception = false;
bool report_on_signal = false;
bool experimental_shadow_realm = false;
size_t thread_max_old_space_size = 0;
uint64_t thread_max_old_space_size = 0;
std::string report_signal = "SIGUSR2";
inline EnvironmentOptions* get_per_env_options();
void CheckOptions(std::vector<std::string>* errors) override;
Expand Down