Skip to content

test: refactor test-net-connect-options-ipv6 #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: refactor test-net-connect-options-ipv6 #4395

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec45fa
test: refactor test-net-connect-options-ipv6
Trott Dec 23, 2015
f4d71db
fixup: do not remove listener because we are no longer adding it
Trott Dec 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: refactor test-net-connect-options-ipv6 
Remove unused variable and refactor checking for event firing.
  • Loading branch information
@Trott
Trott committed Dec 23, 2015
commit 2ec45fa4aa825319f8185d3a41584d5f238466af
20 changes: 3 additions & 17 deletions test/parallel/test-net-connect-options-ipv6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,20 @@
const common = require('../common');
const assert = require('assert');
const net = require('net');
const dns = require('dns');

if (!common.hasIPv6) {
console.log('1..0 # Skipped: no IPv6 support');
return;
}

var serverGotEnd = false;
var clientGotEnd = false;

const hosts = common.localIPv6Hosts;
var hostIdx = 0;
var host = hosts[hostIdx];
var localhostTries = 10;

const server = net.createServer({allowHalfOpen: true}, function(socket) {
socket.resume();
socket.on('end', function() {
serverGotEnd = true;
});
socket.on('end', common.mustCall(function() {}));
socket.end();
});

Expand All @@ -36,13 +30,12 @@ function tryConnect() {
}, function() {
console.error('client connect cb');
client.resume();
client.on('end', function() {
clientGotEnd = true;
client.on('end', common.mustCall(function() {
setTimeout(function() {
assert(client.writable);
client.end();
}, 10);
});
}));
client.on('close', function() {
server.close();
});
Expand All @@ -62,10 +55,3 @@ function tryConnect() {
throw err;
});
}

process.on('exit', onExit);
function onExit() {
console.error('exit', serverGotEnd, clientGotEnd);
assert(serverGotEnd);
assert(clientGotEnd);
}