Skip to content

test_runner: pass signal on timeout #43911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jul 24, 2022
Merged

test_runner: pass signal on timeout #43911

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
235ea83
test_runner: pass signal on timeout
MoLow Jul 20, 2022
1d2898a
Update test/parallel/test-runner-misc.js
MoLow Jul 24, 2022
aa51f7a
Apply suggestions from code review
MoLow Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/parallel/test-runner-misc.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@MoLow @aduh95
MoLow and aduh95 authored Jul 24, 2022
commit 1d2898ac57e86088804cf9095b5fdba81b366062
2 changes: 1 addition & 1 deletion test/parallel/test-runner-misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if (process.argv[2] === 'child') {
assert.strictEqual(signal.aborted, false);
testSignal = signal;
await setTimeout(50);
})).then(() => {
})).finally(common.mustCall(() => {
test(() => assert.strictEqual(testSignal.aborted, true));
});
Comment thread
MoLow marked this conversation as resolved.
Outdated
} else assert.fail('unreachable');
Expand Down