Skip to content

fix: avoid override by assignment #43907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Jul 24, 2022
Merged

fix: avoid override by assignment #43907

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b8004c
fix: avoid override by assignment
erights Jul 20, 2022
04bc784
fix: lint
erights Jul 20, 2022
7b8f1ba
lint rules wants trailing commas
erights Jul 20, 2022
db45fa6
lint rules wants trailing commas
erights Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: avoid override by assignment
  • Loading branch information
@erights
erights committed Jul 20, 2022
commit 7b8004c34e29dc2473dfd94793ea27fe206e3c65
11 changes: 8 additions & 3 deletions lib/internal/process/per_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const {
Float64Array,
NumberMAX_SAFE_INTEGER,
ObjectFreeze,
ObjectDefineProperty,
ReflectApply,
RegExpPrototypeExec,
SafeArrayIterator,
Expand Down Expand Up @@ -371,9 +372,13 @@ function buildAllowedFlags() {
return SetPrototypeValues(this[kInternal].set);
}
}
NodeEnvironmentFlagsSet.prototype.keys =
NodeEnvironmentFlagsSet.prototype[SymbolIterator] =
NodeEnvironmentFlagsSet.prototype.values;
const flagSetValues = NodeEnvironmentFlagsSet.prototype.values;
ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, SymbolIterator, {
value: flagSetValues
Comment thread
erights marked this conversation as resolved.
Outdated
});
ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, 'keys', {
value: flagSetValues
Comment thread
erights marked this conversation as resolved.
Outdated
});

ObjectFreeze(NodeEnvironmentFlagsSet.prototype.constructor);
ObjectFreeze(NodeEnvironmentFlagsSet.prototype);
Expand Down