Skip to content

buffer,lib: update atob to align wpt's base64.json #43901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 6 commits into from
Closed

buffer,lib: update atob to align wpt's base64.json #43901

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
164a4fd
buffer,lib: update atob to align wpt's base64.json
XadillaX Jul 19, 2022
20a2587
f
XadillaX Jul 19, 2022
156937f
f
XadillaX Jul 19, 2022
c8edb80
Update lib/buffer.js
XadillaX Jul 28, 2022
c43f223
Update lib/buffer.js
XadillaX Jul 28, 2022
08dfdac
f
XadillaX Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/buffer.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@XadillaX @aduh95
XadillaX and aduh95 committed Oct 8, 2022
commit c43f22363b84943d13f02a546c21d256cdf477ad
2 changes: 1 addition & 1 deletion lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ function atob(input) {
// ASCII whitespace char codes.
nonAsciiWhitespaceCharCount++;

if (index === kForgivingBase64AllowedChars.length - 1) {
if (index === kForgivingBase64AllowedChars.length - 1 && equalCharCount !== 2) {
// The last element of `kForgivingBase64AllowedChars` is the `=`
Comment thread
aduh95 marked this conversation as resolved.
Outdated
equalCharCount++;
} else if (equalCharCount) {
Expand Down