Skip to content

events: expose CustomEvent on the global scope via a CLI flag #43885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jul 23, 2022
Merged

events: expose CustomEvent on the global scope via a CLI flag #43885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c6cc6e
events: expose CustomEvent on global with CLI flag
daeyeon Jul 18, 2022
323ca0f
fixup: clarify the test
daeyeon Jul 18, 2022
6bc0655
fixup: update the wpt event test
daeyeon Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: clarify the test 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed Jul 18, 2022
commit 323ca0f36c9b1457a00f6d3ad37a0feacc53801e
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ module.exports = {
ByteLengthQueuingStrategy: 'readable',
CompressionStream: 'readable',
CountQueuingStrategy: 'readable',
CustomEvent: 'readable',
Crypto: 'readable',
CryptoKey: 'readable',
DecompressionStream: 'readable',
Expand Down
13 changes: 4 additions & 9 deletions test/parallel/test-global-customevent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
// Flags: --experimental-global-customevent --expose-internals
'use strict';

const common = require('../common');
require('../common');
const { strictEqual, ok } = require('node:assert');
const { Worker, isMainThread } = require('worker_threads');
const { CustomEvent } = require('internal/event_target');
const { CustomEvent: internalCustomEvent } = require('internal/event_target');

// Global
ok(CustomEvent);
strictEqual(globalThis.CustomEvent, CustomEvent);

if (isMainThread) {
const w = new Worker(__filename);
w.on('message', common.mustNotCall());
w.on('error', common.mustNotCall());
}
strictEqual(CustomEvent, internalCustomEvent);