Skip to content

stream: improve ArrayBufferView validation in respondWithNewView() #43866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Jul 24, 2022
Merged

stream: improve ArrayBufferView validation in respondWithNewView() #43866

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3dc3627
stream: improve `respondWithNewView()`
daeyeon Jul 16, 2022
958ee56
fixup: add a counter for passed tests
daeyeon Jul 21, 2022
593536f
fixup: add `isViewedArrayBufferDetached` in JS
daeyeon Jul 21, 2022
97408ed
fixup: remove the c++ part
daeyeon Jul 21, 2022
ec99eb9
fixup: revert unnecessary test changes
daeyeon Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add a counter for passed tests 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed Jul 21, 2022
commit 958ee56bc25d2028b4439c8a50a07f8ef055c9e6
20 changes: 14 additions & 6 deletions test/parallel/test-whatwg-readablebytestream-bad-buffers-and-views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
const common = require('../common');
const assert = require('node:assert');

let pass = 0;

{
// ReadableStream with byte source: respondWithNewView() throws if the
// supplied view's buffer has a different length (in the closed state)
Expand All @@ -12,9 +14,11 @@ const assert = require('node:assert');

c.close();

assert.throws(() => {
c.byobRequest.respondWithNewView(view);
}, RangeError);
assert.throws(() => c.byobRequest.respondWithNewView(view), {
code: 'ERR_INVALID_ARG_VALUE',
name: 'RangeError',
});
pass++;
}),
type: 'bytes',
});
Expand All @@ -34,13 +38,17 @@ const assert = require('node:assert');
const view = new Uint8Array([1, 2, 3]);
reader.read(view);

assert.throws(() => {
c.byobRequest.respondWithNewView(view);
}, TypeError);
assert.throws(() => c.byobRequest.respondWithNewView(view), {
code: 'ERR_INVALID_STATE',
name: 'TypeError',
});
pass++;
}),
type: 'bytes',
});

const reader = stream.getReader({ mode: 'byob' });
reader.read(new Uint8Array([4, 5, 6]));
}

process.on('exit', () => assert.strictEqual(pass, 2));