Skip to content

test: ensure NODE_EXTRA_CA_CERTS not set before tests #43858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 20, 2022
Merged

test: ensure NODE_EXTRA_CA_CERTS not set before tests #43858

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ede0a5
test: ensure NODE_EXTRA_CA_CERTS not set before tests
Jul 16, 2022
f6a777f
Update test/parallel/test-tls-env-extra-ca-file-load.js
KrayzeeKev Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: ensure NODE_EXTRA_CA_CERTS not set before tests 
The 'test-tls-env-extra-ca-file-load.js' test assumes that
NODE_EXTRA_CA_CERTS is not set. If the build environment
happens to have it set, this test will fail. This change
deletes that env var before running the test.
  • Loading branch information
Kevin Lentin committed Jul 16, 2022
commit 1ede0a59b43b64fc494da4fdea56ef36bf1eefde
2 changes: 2 additions & 0 deletions test/parallel/test-tls-env-extra-ca-file-load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ if (process.argv[2] !== 'child') {
const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
const extendsEnv = (obj) => ({ ...process.env, ...obj });

// Clean the starting state
Comment thread
KrayzeeKev marked this conversation as resolved.
Outdated
delete process.env.NODE_EXTRA_CA_CERTS;
[
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),
Expand Down