Skip to content

tty: fix TypeError when stream is closed #43803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Aug 24, 2022
Merged

tty: fix TypeError when stream is closed #43803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tty: fix TypeError when stream is closed 
Fixes: #41330
  • Loading branch information
@aduh95
aduh95 committed Aug 1, 2022
commit 9e6812fab8ca3f60d8cfd4dc1c882ddc12634e67
2 changes: 1 addition & 1 deletion lib/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ ObjectSetPrototypeOf(ReadStream, net.Socket);

ReadStream.prototype.setRawMode = function(flag) {
flag = !!flag;
const err = this._handle.setRawMode(flag);
const err = this._handle?.setRawMode(flag);
if (err) {
this.emit('error', errors.errnoException(err, 'setRawMode'));
return this;
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-repl-stdin-push-null.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';
const common = require('../common');

if (!process.stdin.isTTY) {
common.skip('does not apply on non-TTY stdin');
}

process.stdin.destroy();
process.stdin.setRawMode(true);