Skip to content

util: avoid inline access to Symbol.iterator #43683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 9, 2022
Merged

util: avoid inline access to Symbol.iterator #43683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
util: avoid inline access to Symbol.iterator
  • Loading branch information
@cola119
cola119 committed Jul 5, 2022
commit 1b3b5ee4c95b37ce2dc7e8cb7f0c080dc8b8f833
2 changes: 1 addition & 1 deletion lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ function formatRaw(ctx, value, recurseTimes, typedArray) {
// Iterators and the rest are split to reduce checks.
// We have to check all values in case the constructor is set to null.
// Otherwise it would not possible to identify all types properly.
if (value[SymbolIterator] || constructor === null) {
if (SymbolIterator in value || constructor === null) {
noIterator = false;
if (ArrayIsArray(value)) {
// Only set the constructor for non ordinary ("Array [...]") arrays.
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3240,3 +3240,12 @@ assert.strictEqual(
'-123_456_789.123_456_78'
);
}

// Regression test for https://github.com/nodejs/node/issues/41244
{
assert.strictEqual(util.inspect({
get [Symbol.iterator]() {
throw new Error();
}
}), '{ [Symbol(Symbol.iterator)]: [Getter] }');
}