Skip to content

test: fix domain-top-level-error-handler-throw #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
Closed

test: fix domain-top-level-error-handler-throw #4364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix domain-top-level-error-handler-throw 
Check the stderr output in the `close` event as it's not guaranteed to
be fully available when the `exit` event is fired.
  • Loading branch information
@santigimeno
santigimeno committed Dec 23, 2015
commit c52fdd9a3ca9b462e7971d25096617551e8bebed
4 changes: 3 additions & 1 deletion test/parallel/test-domain-top-level-error-handler-throw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ if (process.argv[2] === 'child') {
stderrOutput += data.toString();
});

child.on('exit', function onChildExited(exitCode, signal) {
child.on('close', function onChildClosed() {
assert(stderrOutput.indexOf(domainErrHandlerExMessage) !== -1);
assert(stderrOutput.indexOf(internalExMessage) === -1);
});

child.on('exit', function onChildExited(exitCode, signal) {
var expectedExitCode = 7;
var expectedSignal = null;

Expand Down