Skip to content

src,stream: change return type to Maybe #43575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jul 7, 2022
Merged

src,stream: change return type to Maybe #43575

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be8fbda
src,stream: change return type to `Maybe`
daeyeon Jun 25, 2022
8a7c26f
fixup: create using declarations
daeyeon Jun 26, 2022
83cafe8
fixup: check the uv_handle_type
daeyeon Jun 27, 2022
c0e0bea
fixup: add TryCatchScope
daeyeon Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: check the uv_handle_type 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
  • Loading branch information
@daeyeon
daeyeon committed Jun 28, 2022
commit 83cafe85a70ee0774304ee565ff53d13e0628ca8
11 changes: 7 additions & 4 deletions src/stream_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,13 @@ Maybe<void> LibuvStreamWrap::OnUvRead(ssize_t nread, const uv_buf_t* buf) {
}

Local<Object> local_pending_obj;
if (pending_obj.ToLocal(&local_pending_obj) &&
object()->Set(env()->context(),
env()->pending_handle_string(),
local_pending_obj).IsNothing()) {
if (type != UV_UNKNOWN_HANDLE &&
(!pending_obj.ToLocal(&local_pending_obj) ||
object()
->Set(env()->context(),
env()->pending_handle_string(),
local_pending_obj)
.IsNothing())) {
return Nothing<void>();
}
}
Expand Down