Skip to content

tools: update eslint to 8.18.0 #43479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 19, 2022
Merged

tools: update eslint to 8.18.0 #43479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5ad2ae
tools: update eslint to 8.18.0
nodejs-github-bot Jun 19, 2022
b48b9f0
stream,test: remove unneeded eslint-disable directives
lpinca Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream,test: remove unneeded eslint-disable directives
  • Loading branch information
@lpinca
lpinca committed Jun 19, 2022
commit b48b9f0765e286390733f5bd47278824299d870b
1 change: 0 additions & 1 deletion lib/internal/streams/operators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ function asIndexedPairs(options = undefined) {
}

async function some(fn, options = undefined) {
// eslint-disable-next-line no-unused-vars
for await (const unused of filter.call(this, fn, options)) {
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-opendir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ doAsyncIterBreakTest().then(common.mustCall());
async function doAsyncIterReturnTest() {
const dir = await fs.promises.opendir(testDir);
await (async function() {
for await (const dirent of dir) { // eslint-disable-line no-unused-vars
for await (const dirent of dir) {
return;
}
})();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stream-readable-async-iterators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ async function tests() {
});

await (async () => {
for await (const d of readable) { // eslint-disable-line no-unused-vars
for await (const d of readable) {
return;
}
})();
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-whatwg-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,6 @@ class Source {
});

async function read(stream) {
// eslint-disable-next-line no-unused-vars
for await (const _ of stream.values({ preventCancel: true }))
return;
}
Expand All @@ -1319,7 +1318,6 @@ class Source {
const stream = new ReadableStream(source);

async function read(stream) {
// eslint-disable-next-line no-unused-vars
for await (const _ of stream.values({ preventCancel: false }))
return;
}
Expand Down