Skip to content

test: simplify the test cases in http timeouts mix #43470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrJithil wants to merge 2 commits into from
Closed

test: simplify the test cases in http timeouts mix #43470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6bb8f0
test: simplify the test cases in http timeouts mix
MrJithil Jun 18, 2022
bbc0538
ensure there are no never settling promises
aduh95 Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ensure there are no never settling promises
  • Loading branch information
@aduh95
aduh95 authored Jun 27, 2022
commit bbc053875c7e8673d8bfbe50471a7f99ded889e3
4 changes: 2 additions & 2 deletions test/parallel/test-http-server-request-timeouts-mixed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function createClient(server) {
return request;
}

server.listen(0, common.mustCall(async () => {
server.listen(0, common.mustCall(() => (async () => {
// Create first and second request and set headers
const request1 = createClient(server);
const request2 = createClient(server);
Expand Down Expand Up @@ -106,4 +106,4 @@ server.listen(0, common.mustCall(async () => {
assert(request4.response.startsWith(responseOk));
assert(request5.response.startsWith(responseTimeout)); // It is expired due to headersTimeout
server.close();
}));
})().then(common.mustCall())));