Skip to content

module: add isBuiltin method #43396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 24 commits into from
Jul 8, 2022
Merged

module: add isBuiltin method #43396

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ec1f95a
module: add isBuiltIn method
hemanth Jun 14, 2022
2376045
Use regex instead
hemanth Jun 14, 2022
06c135a
using primordial instead
hemanth Jun 14, 2022
62a4280
importing StringPrototypeReplace
hemanth Jun 14, 2022
57f5686
doc: add isBuiltIn
hemanth Jun 14, 2022
55916da
fix: use String
hemanth Jun 15, 2022
075ae02
using the placeholder REPLACEME
hemanth Jun 15, 2022
7a08b8f
prefix to tests
hemanth Jun 16, 2022
8c78587
avoid reassigning function args
hemanth Jun 16, 2022
cfc1a07
fix: falsy value assertion
hemanth Jun 16, 2022
8ab8589
fix: also support scheme only modules
hemanth Jun 19, 2022
deb9010
removed auto imported console.
hemanth Jun 19, 2022
420c8eb
fix: prefix only module checks
hemanth Jun 19, 2022
4bab085
proper check for prefixes
hemanth Jun 19, 2022
9a4fe4a
Update lib/internal/modules/cjs/loader.js
hemanth Jun 21, 2022
3b2cd57
Update test/parallel/test-module-isBuiltIn.js
hemanth Jun 23, 2022
eafd131
fix: using Set for better perf
hemanth Jun 23, 2022
1e81d07
fix: avoid mutation
hemanth Jun 23, 2022
0910fe0
use slice rather
hemanth Jun 23, 2022
1e7b74f
fix: avoid assignment.
hemanth Jun 23, 2022
15b71f3
allBuiltins as a Set
hemanth Jun 24, 2022
70e823a
chore: naming it isBuiltin instead & using flatMap
hemanth Jun 24, 2022
fc63117
doc: isBuiltin
hemanth Jun 24, 2022
b6033d2
chore: rename to isBuiltin
hemanth Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use regex instead 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@hemanth @ljharb
hemanth and ljharb authored Jun 14, 2022
commit 2376045b496528dad93ec859d67bd096a8ea12b3
2 changes: 1 addition & 1 deletion lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,7 @@ Module.syncBuiltinESMExports = function syncBuiltinESMExports() {
};

Module.isBuiltIn = function isBuiltIn(moduleName) {
Comment thread
hemanth marked this conversation as resolved.
Outdated
moduleName = String(moduleName).replace('node:', '');
moduleName = StringPrototypeReplace(moduleName, /^node:/, '');
return Module.builtinModules.includes(moduleName);
Comment thread
hemanth marked this conversation as resolved.
Outdated
};

Expand Down