Skip to content

loader: require.resolve should throw for unknown builtin modules #43336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Jun 17, 2022
Merged

loader: require.resolve should throw for unknown builtin modules #43336

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21bfcaa
loader: make require.resolve throw error for unknown builtin modules
zhmushan Jun 7, 2022
9bbf815
Update lib/internal/modules/cjs/loader.js
zhmushan Jun 7, 2022
c65f329
Update test/parallel/test-require-resolve.js
zhmushan Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/modules/cjs/loader.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@zhmushan @aduh95
zhmushan and aduh95 authored Jun 7, 2022
commit 9bbf815c2af774b2a4a181c66eb41d037ab0597c
17 changes: 9 additions & 8 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,14 +854,15 @@ Module._load = function(request, parent, isMain) {
};

Module._resolveFilename = function(request, parent, isMain, options) {
if ((
StringPrototypeStartsWith(request, 'node:') &&
NativeModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5))
) ||
(
NativeModule.canBeRequiredByUsers(request) &&
NativeModule.canBeRequiredWithoutScheme(request)
)) {
if (
(
StringPrototypeStartsWith(request, 'node:') &&
NativeModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5))
) || (
NativeModule.canBeRequiredByUsers(request) &&
NativeModule.canBeRequiredWithoutScheme(request)
)
) {
return request;
}

Expand Down