Skip to content

readline: fix question stack overflow #43320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 12, 2022
Merged

readline: fix question stack overflow #43320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35fda91
readline: fix question stack overflow
chapko Jun 5, 2022
473f03c
readline: add test for promisified question
chapko Jun 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
readline: add test for promisified question
  • Loading branch information
@chapko
chapko committed Jun 5, 2022
commit 473f03c07014043801cf943b6edaad2481a1b116
15 changes: 14 additions & 1 deletion test/parallel/test-readline-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ for (let i = 0; i < 12; i++) {
// Calling the question callback with abort signal
{
const [rli] = getInterface({ terminal });
const signal = new AbortController().signal;
const { signal } = new AbortController();
rli.question('foo?', { signal }, common.mustCall((answer) => {
assert.strictEqual(answer, 'bar');
}));
Expand Down Expand Up @@ -1041,6 +1041,19 @@ for (let i = 0; i < 12; i++) {
rli.close();
}

// Calling the promisified question with abort signal
{
const [rli] = getInterface({ terminal });
const question = util.promisify(rli.question).bind(rli);
const { signal } = new AbortController();
question('foo?', { signal })
.then(common.mustCall((answer) => {
assert.strictEqual(answer, 'bar');
}));
rli.write('bar\n');
rli.close();
}

// Aborting a question
{
const ac = new AbortController();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-readline-promises-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ for (let i = 0; i < 12; i++) {
// Calling the question callback with abort signal
{
const [rli] = getInterface({ terminal });
const signal = new AbortController().signal;
const { signal } = new AbortController();
rli.question('foo?', { signal }).then(common.mustCall((answer) => {
assert.strictEqual(answer, 'bar');
}));
Expand Down