Skip to content

doc: clarify use of deps/icu-small #43287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 4 commits into from
Closed

doc: clarify use of deps/icu-small #43287

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cc3374
doc: clarify use of deps/icu-small
mhdawson Jun 1, 2022
44f3e3f
Update doc/contributing/maintaining-icu.md
mhdawson Jun 1, 2022
bf1c5b8
Update doc/contributing/maintaining-icu.md
mhdawson Jun 13, 2022
cb46453
Update doc/contributing/maintaining-icu.md
mhdawson Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/contributing/maintaining-icu.md 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@mhdawson @aduh95
mhdawson and aduh95 authored Jun 13, 2022
commit bf1c5b8dce416dde3ba9453aa5cba14afce47ddd
2 changes: 1 addition & 1 deletion doc/contributing/maintaining-icu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ functionality. To quote from icu-project.org:

If Node.js is configured to use its built-in ICU,
it uses a strict subset of ICU which is in
Copy link
Copy Markdown
Member

@srl295 srl295 Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless it's worth noting that the subset is not by locale (and type), but by type.

It's further confusing that 'small-icu' is an option still, but is !== the small-icu directory.

[deps/icu-small](https://github.com/nodejs/node/tree/master/deps/icu-small).
[deps/icu-small](https://github.com/nodejs/node/tree/HEAD/deps/icu-small).
A good description of the different ways Node.js can be build with ICU
support are covered in [api/intl.html](https://nodejs.org/api/intl.html).

Expand Down