Skip to content

net: add ability to reset a tcp socket #43112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PupilTong wants to merge 5 commits into from
Closed

net: add ability to reset a tcp socket #43112

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfa6d57
net: add ability to reset a tcp socket
PupilTong May 15, 2022
a417977
net: add ability to reset a tcp socket
PupilTong May 15, 2022
f49e8b0
net: add ability to reset a tcp socket
PupilTong May 15, 2022
4338ec3
net: add ability to reset a tcp socket
PupilTong May 15, 2022
751f2f9
net: add ability to reset a tcp socket
PupilTong May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
net: add ability to reset a tcp socket 
make it possible to forcibly rest a tcp socket:

* add a new method `Socket.prototype.resetAndDestroy`

* add a new flag `resetAndClosing` to make `_destroy` calls
the `reset` instead of close while destroying a Socket.

* add new methods `TCPWrap::Reset` to be a wrap of `uv_tcp_close_reset`

* change `HandleWrap::state_` from private to protected.
This is essential for keeping the same behaviour between
`TCPWrap::Reset` and `HandleWrap::Close`

Fixes: #27428
  • Loading branch information
@PupilTong
PupilTong authored and PupilTong committed May 18, 2022
commit 4338ec383417cbd1008b4a4135243b41a0f14381
2 changes: 1 addition & 1 deletion doc/api/net.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ added: REPLACEME

Close the TCP connection by sending an RST packet and destroy the stream.
If this TCP socket is in connecting status, it will send an RST packet and destroy this TCP socket once it is connected.
Otherwise, it will call `socket.destroy` this socket with an `ERR_SOCKET_CLOSED` Error.
Otherwise, it will call `socket.destroy` with an `ERR_SOCKET_CLOSED` Error.
If this is not a TCP socket (for example, a pipe), calling this method will immediately throw an `ERR_INVALID_HANDLE_TYPE` Error.

### `socket.resume()`
Expand Down