Skip to content

assert: make assert.fail less affected by prototype tampering #42918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
May 2, 2022
Merged

assert: make assert.fail less affected by prototype tampering #42918

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce9d18f
assert: make `assert.fail` less affected by prototype tampering
aduh95 Apr 29, 2022
71cda91
fixup! assert: make `assert.fail` less affected by prototype tampering
aduh95 Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! assert: make assert.fail less affected by prototype tampering
  • Loading branch information
@aduh95
aduh95 committed Apr 29, 2022
commit 71cda91437c245f0adad7be0164c44006aac94a1
4 changes: 2 additions & 2 deletions test/parallel/test-assert-fail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ assert.throws(() => {
message: 'custom message'
});

Object.prototype.get = common.mustNotCall()
assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' })
Object.prototype.get = common.mustNotCall();
assert.throws(() => assert.fail(''), { code: 'ERR_ASSERTION' });
delete Object.prototype.get;