esm: graduate top-level-await to stable

Removes the experimental label in the docs and makes the `--experimental-top-level-await` flag a no-op. V8 has removed the harmony flag in V8 9.1 and consider the feature stable, there's no reason to keep it experimental in Node.js.
nodejs · nodejs-github-bot · Apr 28, 2022 · Apr 26, 2022 · Apr 26, 2022 · Apr 26, 2022
commit a55c3f5e4e973b4fdcef0ba7750b0c0eccc3e2dd
diff --git a/doc/api/esm.md b/doc/api/esm.md
@@ -566,8 +566,6 @@ would provide the exports interface for the instantiation of `module.wasm`.
 added: v14.8.0
 -->
 
-> Stability: 1 - Experimental
-
 The `await` keyword may be used in the top level body of an ECMAScript module.
 
 Assuming an `a.mjs` with

diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -432,9 +432,7 @@ void ModuleWrap::Evaluate(const FunctionCallbackInfo<Value>& args) {
   // Otherwise, `result` is the last evaluated value of the module,
   // which could be a promise, which would result in it being incorrectly
   // unwrapped when the higher level code awaits the evaluation.
-  if (env->isolate_data()->options()->experimental_top_level_await) {
-    args.GetReturnValue().Set(result.ToLocalChecked());
-  }
+  args.GetReturnValue().Set(result.ToLocalChecked());
 }
 
 void ModuleWrap::GetNamespace(const FunctionCallbackInfo<Value>& args) {

diff --git a/src/node_options.cc b/src/node_options.cc
@@ -704,14 +704,8 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
             kAllowedInEnvironment);
   Implies("--report-signal", "--report-on-signal");
 
-  AddOption("--experimental-top-level-await",
-            "",
-            &PerIsolateOptions::experimental_top_level_await,
-            kAllowedInEnvironment);
-  AddOption("--harmony-top-level-await", "", V8Option{});
-  Implies("--experimental-top-level-await", "--harmony-top-level-await");
-  Implies("--harmony-top-level-await", "--experimental-top-level-await");
-  ImpliesNot("--no-harmony-top-level-await", "--experimental-top-level-await");
+  AddOption("--experimental-top-level-await", "",
+            NoOp{}, kAllowedInEnvironment);
 
   Insert(eop, &PerIsolateOptions::get_per_env_options);
 }

diff --git a/src/node_options.h b/src/node_options.h
@@ -206,7 +206,6 @@ class PerIsolateOptions : public Options {
   bool node_snapshot = true;
   bool report_uncaught_exception = false;
   bool report_on_signal = false;
-  bool experimental_top_level_await = true;
   std::string report_signal = "SIGUSR2";
   inline EnvironmentOptions* get_per_env_options();
   void CheckOptions(std::vector<std::string>* errors) override;