Skip to content

worker: fix stream & termination race bug #42874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
May 6, 2022
Merged

worker: fix stream & termination race bug #42874

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d55ddfc
worker: fix stream racing with terminate
airtable-keyhanvakil Apr 26, 2022
cf200b5
add test
airtable-keyhanvakil Apr 28, 2022
c57dd41
lint
airtable-keyhanvakil Apr 28, 2022
b17b64f
follow RaisinTen's suggestions
airtable-keyhanvakil May 3, 2022
a7bdb8e
fix node-test-commit-custom-suites-freestyle failure
airtable-keyhanvakil May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
worker: fix stream racing with terminate 
`OnStreamAfterReqFinished` uses `v8::Object::Has` to check if it needs
to call `oncomplete`. `v8::Object::Has` needs to execute Javascript.
However when worker threads are involved, `OnStreamAfterReqFinished` may
be called after the worker thread termination has begun via
`worker.terminate()`. This makes `v8::Object::Has` return `Nothing`,
which triggers an assert.

This diff fixes the issue by simply defaulting us to `false` in the case
where `Nothing` is returned. This is sound because we can't execute
`oncomplete` anyway as the isolate is terminating.

Fixes: #38418
  • Loading branch information
@airtable-keyhanvakil
airtable-keyhanvakil committed Apr 26, 2022
commit d55ddfce3be534964817d766ea59588835d3b386
2 changes: 1 addition & 1 deletion src/stream_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ void ReportWritesToJSStreamListener::OnStreamAfterReqFinished(
stream->ClearError();
}

if (req_wrap_obj->Has(env->context(), env->oncomplete_string()).FromJust())
if (req_wrap_obj->Has(env->context(), env->oncomplete_string()).FromMaybe(false))
async_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv);
}

Expand Down