Skip to content

test: improve lib/internal/webstreams/readablestream.js coverage #42823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
May 5, 2022
Merged

test: improve lib/internal/webstreams/readablestream.js coverage #42823

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a933ea9
test: improve `lib/internal/webstreams/readablestream.js` coverage
fossamagna Apr 22, 2022
293c6fc
test: change that checking only the `code` property
fossamagna Apr 22, 2022
84e8749
test: check that promises of `assert.rejects` is resolved
fossamagna Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: change that checking only the code property
  • Loading branch information
@fossamagna
fossamagna committed Apr 22, 2022
commit 293c6fc39f25629dd4f82e034372df89296e9f7d
5 changes: 0 additions & 5 deletions test/parallel/test-whatwg-readablebytestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,9 @@ class Source {
reader.releaseLock();
assert.rejects(reader.read(new Uint8Array(10)), {
code: 'ERR_INVALID_STATE',
message: 'Invalid state: The reader is not attached to a stream',
});
assert.rejects(reader.cancel(), {
code: 'ERR_INVALID_STATE',
message: 'Invalid state: The reader is not attached to a stream',
});
}

Expand All @@ -232,11 +230,9 @@ class Source {
controller.close();
assert.throws(() => controller.enqueue(new Uint8Array(10)), {
code: 'ERR_INVALID_STATE',
message: 'Invalid state: ReadableStream is already closed',
});
assert.throws(() => controller.close(), {
code: 'ERR_INVALID_STATE',
message: 'Invalid state: ReadableStream is already closed',
});
}

Expand All @@ -250,7 +246,6 @@ class Source {
controller.close();
assert.throws(() => controller.enqueue(new Uint8Array(10)), {
code: 'ERR_INVALID_STATE',
message: 'Invalid state: Controller is already closed',
});
}

Expand Down