Skip to content

test: usemustSucceed instead of mustCall with assert.ifError #42806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
May 5, 2022
Merged

test: usemustSucceed instead of mustCall with assert.ifError #42806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: usemustSucceed instead of mustCall with assert.ifError
  • Loading branch information
@fossamagna
fossamagna committed Apr 21, 2022
commit 61f4d532cbf5d969d96e1e285e03e0eae3932dd5
6 changes: 2 additions & 4 deletions test/parallel/test-fs-opendir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,16 @@ const invalidCallbackObj = {
// Check the opendir async version
fs.opendir(testDir, common.mustSucceed((dir) => {
let sync = true;
dir.read(common.mustCall((err, dirent) => {
dir.read(common.mustSucceed((dirent) => {
assert(!sync);
assert.ifError(err);

// Order is operating / file system dependent
assert(files.includes(dirent.name), `'files' should include ${dirent}`);
assertDirent(dirent);

let syncInner = true;
dir.read(common.mustCall((err, dirent) => {
dir.read(common.mustSucceed((dirent) => {
assert(!syncInner);
assert.ifError(err);

dir.close(common.mustSucceed());
}));
Expand Down