Skip to content

test: use assert.match() instead of assert(regex.test()) #42803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 21, 2022
Merged

test: use assert.match() instead of assert(regex.test()) #42803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: use assert.match() instead of assert(regex.test())
  • Loading branch information
@aduh95
aduh95 committed Apr 20, 2022
commit 981c6f53c078a41f09c2190acaff9c4e23a6a0b1
36 changes: 18 additions & 18 deletions test/parallel/test-runner-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.status, 1);
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stdout.toString(), '');
assert(/^Could not find/.test(child.stderr.toString()));
assert.match(child.stderr.toString(), /^Could not find/);
}

{
Expand All @@ -27,11 +27,11 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert(/ok 1 - .+index\.test\.js/.test(stdout));
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
assert(/not ok 1 - this should fail/.test(stdout));
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
assert(/ok 4 - .+random\.cjs/.test(stdout));
assert.match(stdout, /ok 1 - .+index\.test\.js/);
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
assert.match(stdout, /not ok 1 - this should fail/);
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
assert.match(stdout, /ok 4 - .+random\.cjs/);
}

{
Expand All @@ -43,11 +43,11 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert(/not ok 1 - .+index\.js/.test(stdout));
assert(/ok 2 - .+index\.test\.js/.test(stdout));
assert(/not ok 3 - .+random\.test\.mjs/.test(stdout));
assert(/not ok 1 - this should fail/.test(stdout));
assert(/ok 4 - .+subdir.+subdir_test\.js/.test(stdout));
assert.match(stdout, /not ok 1 - .+index\.js/);
assert.match(stdout, /ok 2 - .+index\.test\.js/);
assert.match(stdout, /not ok 3 - .+random\.test\.mjs/);
assert.match(stdout, /not ok 1 - this should fail/);
assert.match(stdout, /ok 4 - .+subdir.+subdir_test\.js/);
}

{
Expand All @@ -59,7 +59,7 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert(/not ok 1 - .+test-nm\.js/.test(stdout));
assert.match(stdout, /not ok 1 - .+test-nm\.js/);
}

{
Expand All @@ -72,11 +72,11 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert(/ok 1 - .+index\.test\.js/.test(stdout));
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
assert(/not ok 1 - this should fail/.test(stdout));
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
assert(/ok 4 - .+random\.cjs/.test(stdout));
assert.match(stdout, /ok 1 - .+index\.test\.js/);
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
assert.match(stdout, /not ok 1 - this should fail/);
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
assert.match(stdout, /ok 4 - .+random\.cjs/);
}

{
Expand All @@ -102,6 +102,6 @@ const testFixtures = fixtures.path('test-runner');
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stdout.toString(), '');
const stderr = child.stderr.toString();
assert(/--test/.test(stderr));
assert.match(stderr, /--test/);
});
}