Skip to content

lib: ensure TextDecoder only removes utf8 BOM on utf8 encoding #42779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phated wants to merge 5 commits into from
Closed

lib: ensure TextDecoder only removes utf8 BOM on utf8 encoding #42779

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b0cb91
lib: ensure `TextDecoder` only removes `utf8` BOM on `utf8` encoding
phated Apr 18, 2022
cdb76ff
linting
phated Apr 18, 2022
9388ab4
typo in encoding
phated Apr 18, 2022
72ea0dc
Use correctly decoded string
phated Apr 19, 2022
be430d5
might need encoding for Buffer.from
phated Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting
  • Loading branch information
@phated
phated committed Apr 18, 2022
commit cdb76ff34b3020102b560d19265af9fcd0383124
4 changes: 2 additions & 2 deletions test/parallel/test-whatwg-encoding-custom-textdecoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ assert(TextDecoder);
// This is a utf16le buffer with a utf8 BOM,
// which should not be removed
const buf = Buffer.from([0xef, 0xbb, 0xbf, 0x74, 0x00, 0x65,
0x00, 0x73, 0x00, 0x74, 0x00, 0xac,
0x20])
0x00, 0x73, 0x00, 0x74, 0x00, 0xac,
0x20]);
const dec = new TextDecoder(i);
assert.strictEqual(dec.encoding, 'utf-16-le');
const res = dec.decode(buf);
Expand Down