Skip to content

debugger: fix TypeError of list command in inspector repl #42776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 5 commits into from
May 22, 2022
+33 −0
Merged

debugger: fix TypeError of list command in inspector repl #42776

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e45af10
debugger: throw debugger error when the frame is missing
cola119 Apr 20, 2022
832435f
test: fix flaky test
cola119 Apr 20, 2022
88f48e0
test: refactor into async-await
cola119 Apr 20, 2022
4cbbd47
test: fix flaky test
cola119 Apr 22, 2022
2ac7da0
test: fix newline characters
cola119 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: refactor into async-await
  • Loading branch information
@cola119
cola119 committed Apr 22, 2022
commit 88f48e0b569db8f6590c656e8bf97feee0fa4ea1
40 changes: 17 additions & 23 deletions test/sequential/test-debugger-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,20 @@ const assert = require('assert');

const cli = startCLI([fixtures.path('debugger/three-lines.js')]);

cli.waitForInitialBreak()
.then(() => cli.waitForPrompt())
.then(() => cli.command('list(0)'))
.then(() => {
assert.match(cli.output, /> 1 let x = 1;/);
})
.then(() => cli.command('list(1)'))
.then(() => {
assert.match(cli.output, /> 1 let x = 1;\n {2}2 x = x \+ 1;/);
})
.then(() => cli.command('list(10)'))
.then(() => {
assert.match(cli.output, /> 1 let x = 1;\n {2}2 x = x \+ 1;\n {2}3 module\.exports = x;\n {2}4 /);
})
.then(() => cli.command('c'))
.then(() => cli.waitFor(/disconnect/))
.then(() => cli.waitFor(/debug> $/))
.then(() => cli.command('list()'))
.then(() => {
assert.match(cli.output, /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/);
})
.finally(() => cli.quit())
.then(common.mustCall());
(async () => {
await cli.waitForInitialBreak();
await cli.waitForPrompt();
await cli.command('list(0)');
assert.match(cli.output, /> 1 let x = 1;/);
await cli.command('list(1)');
assert.match(cli.output, /> 1 let x = 1;\n {2}2 x = x \+ 1;/);
await cli.command('list(10)');
assert.match(cli.output, /> 1 let x = 1;\n {2}2 x = x \+ 1;\n {2}3 module\.exports = x;\n {2}4 /);
await cli.command('c');
await cli.waitFor(/disconnect/);
await cli.waitFor(/debug> $/);
await cli.command('list()');
assert.match(cli.output, /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/);
})()
.finally(() => cli.quit())
.then(common.mustCall());