Skip to content

test: improve observable ICU behaviour coverage #42683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
May 5, 2022
Merged

test: improve observable ICU behaviour coverage #42683

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7516940
test: improve observable ICU behaviour coverage
LiviaMedeiros Apr 10, 2022
a1f2973
squash: skip tests with mocked env on OSX
LiviaMedeiros Apr 10, 2022
cdd678d
squash: skip tests if ICU is too old
LiviaMedeiros Apr 13, 2022
68cac1d
squash: add detection for unmockable env
LiviaMedeiros Apr 29, 2022
ac6e3f4
squash: fix test in Workers
LiviaMedeiros Apr 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: fix test in Workers
  • Loading branch information
@LiviaMedeiros
LiviaMedeiros committed Apr 30, 2022
commit ac6e3f447ec93f9ef201390edb19787622e7b283
28 changes: 20 additions & 8 deletions test/parallel/test-icu-env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,26 @@ if (isMockable) {

// Tests with process.env mutated inside
{
assert.strictEqual(
isSet(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toString()))),
true
);
assert.strictEqual(
isSet(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toLocaleString()))),
true
);
// process.env.TZ is not intercepted in Workers
if (common.isMainThread) {
assert.strictEqual(
isSet(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toString()))),
true
);
assert.strictEqual(
isSet(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toLocaleString()))),
true
);
} else {
assert.strictEqual(
isPack(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toString()))),
true
);
assert.strictEqual(
isPack(zones.map((TZ) => runEnvInside({ TZ }, () => new Date(333333333333).toLocaleString()))),
true
);
}

assert.strictEqual(
isPack(locales.map((LANG) => runEnvInside({ LANG, TZ: 'Europe/Zurich' }, () => new Date(333333333333).toString()))),
Expand Down