Skip to content

doc: fix the example for embedders #42671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 13, 2022
+1 −0
Merged

doc: fix the example for embedders #42671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: fix the example for embedders 
Refs: #42670
  • Loading branch information
@mmomtchev
mmomtchev committed Apr 9, 2022
commit b3c0526af2c6bcf287c6070644ecb83136c08754
1 change: 1 addition & 0 deletions doc/api/embedding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
{
Locker locker(isolate);
Isolate::Scope isolate_scope(isolate);
HandleScope handle_scope(isolate);
// The v8::Context needs to be entered when node::CreateEnvironment() and
// node::LoadEnvironment() are being called.
Context::Scope context_scope(setup->context());
Expand Down