Skip to content

doc: add note about header values encoding #42624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShogunPanda wants to merge 2 commits into from
Closed

doc: add note about header values encoding #42624

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec46a75
doc: add note about header values encoding
ShogunPanda Apr 6, 2022
5518dfe
doc: use better example
ShogunPanda Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add note about header values encoding
  • Loading branch information
@ShogunPanda
ShogunPanda committed Apr 6, 2022
commit ec46a75ccabb2be32ace3236fc82380cf35b01cd
12 changes: 12 additions & 0 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,17 @@ or
request.setHeader('Cookie', ['type=ninja', 'language=javascript']);
```

When the value is a string an exception will be thrown if it contains
characters outside the `latin1` encoding.

If you need to pass UTF-8 characters in the value please encode the value
using the [RFC 8187][] standard.

```js
const filename = 'Rock 🎵.txt';
request.setHeader('Content-Disposition', `inline; filename*=utf-8''${encodeURIComponent(filename)}`);
Comment thread
ShogunPanda marked this conversation as resolved.
Outdated
```

### `request.setNoDelay([noDelay])`

<!-- YAML
Expand Down Expand Up @@ -3406,6 +3417,7 @@ try {
}
```

[RFC 8187]: https://www.rfc-editor.org/rfc/rfc8187.txt
[`'checkContinue'`]: #event-checkcontinue
[`'finish'`]: #event-finish
[`'request'`]: #event-request
Expand Down