Skip to content

test: fix debug-port-cluster flakiness #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santigimeno wants to merge 1 commit into from
Closed

test: fix debug-port-cluster flakiness #4258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix debug-port-cluster flakiness 
The test was assuming that the 'all workers are running' text was received
by the parent process in a separate chunk from the other texts. This might
not always be the case, causing the test never reaches the exit condition.
Fix it by checking every line received.
  • Loading branch information
@santigimeno
santigimeno committed Dec 12, 2015
commit b8eed1e61eef7a964462b31e31474bf98f3fc09d
17 changes: 9 additions & 8 deletions test/parallel/test-debug-port-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,15 @@ child.stderr.on('data', function(data) {
var lines = data.toString().replace(/\r/g, '').trim().split('\n');
var line = lines[0];

lines.forEach(function(ln) { console.log('> ' + ln); } );

if (line === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines = outputLines.concat(lines);
}
lines.forEach((ln, i) => {
console.log(i + '> ' + ln);
if (ln === 'all workers are running') {
assertOutputLines();
process.exit();
} else {
outputLines.push(ln);
}
});
});

process.on('exit', function onExit() {
Expand Down