Skip to content

crypto: do not add undefined hash in webcrypto normalizeAlgorithm #42559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 3, 2022
Merged

crypto: do not add undefined hash in webcrypto normalizeAlgorithm #42559

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379b548
crypto: do not add undefined hash in webcrypto normalizeAlgorithm
panva Apr 1, 2022
04e4cc8
fixup! crypto: do not add undefined hash in webcrypto normalizeAlgorithm
panva Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! crypto: do not add undefined hash in webcrypto normalizeAlgorithm
  • Loading branch information
@panva
panva committed Apr 2, 2022
commit 04e4cc868dc8ace3cb94346ded9ec0ae3a96a984
1 change: 0 additions & 1 deletion lib/internal/crypto/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ function normalizeAlgorithm(algorithm) {
throw lazyDOMException('Unrecognized name.', 'NotSupportedError');
}


function hasAnyNotIn(set, checks) {
for (const s of set)
if (!ArrayPrototypeIncludes(checks, s))
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-webcrypto-utils.js → test/parallel/test-webcrypto-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ const {
} = require('internal/crypto/util');

{
// Check that normalizeAlgorithm does not add an undefined hash property
// Check that normalizeAlgorithm does not add an undefined hash property.
assert.strictEqual('hash' in normalizeAlgorithm({ name: 'ECDH' }), false);
assert.strictEqual('hash' in normalizeAlgorithm('ECDH'), false);
}

{
// Check that normalizeAlgorithm does not mutate object inputs
// Check that normalizeAlgorithm does not mutate object inputs.
const algorithm = { name: 'ECDH', hash: 'SHA-256' };
assert.strictEqual(normalizeAlgorithm(algorithm) !== algorithm, true);
assert.deepStrictEqual(algorithm, { name: 'ECDH', hash: 'SHA-256' });
Expand Down