Skip to content

node-api: enable napi_ref for all value types #42557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmoroz wants to merge 5 commits into from
Closed

node-api: enable napi_ref for all value types #42557

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
579d44c
node-api: enable napi_ref for all value types
vmoroz Oct 10, 2022
e108b5e
attempt to fix lint issues
vmoroz Oct 10, 2022
e629646
add two reference tests that use NAPI_MODULE_INIT
vmoroz Oct 28, 2022
246e224
remove _canBeWeak and change names
vmoroz Oct 28, 2022
c794f31
update spelling in docs based based on code review
vmoroz Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update spelling in docs based based on code review
  • Loading branch information
@vmoroz
vmoroz committed Nov 4, 2022
commit c794f3176ebd6fda512f3ef54a94e7f3e0c836c8
4 changes: 2 additions & 2 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2081,7 +2081,7 @@ A module can override the set of its enabled features by adding
value of the global `node_api_module_features` variable.
To check enabled features use the `node_api_is_feature_enabled` function.

For example, to disables `node_api_feature_reference_all_types` feature we can
For example, to disable `node_api_feature_reference_all_types` feature we can
exclude its bit from the `node_api_default_features` set:

```c
Expand Down Expand Up @@ -5758,7 +5758,7 @@ NAPI_EXTERN napi_status node_api_is_feature_enabled(napi_env env,
```

* `[in] env`: The environment that the API is invoked under.
* `[in] feature`: The feature that we want to test.
* `[in] feature`: The features that we want to test.
* `[out] result`: Whether the feature or a set of features are enabled.

Returns `napi_ok` if the API succeeded.
Expand Down