Skip to content

buffer: fix atob input validation #42539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Apr 2, 2022
Merged

buffer: fix atob input validation #42539

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae80c08
buffer: fix `atob` input validation
aduh95 Mar 31, 2022
3be9788
fixup! buffer: fix `atob` input validation
aduh95 Mar 31, 2022
a63982f
fixup! buffer: fix `atob` input validation
aduh95 Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! buffer: fix atob input validation 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@aduh95 @targos
aduh95 and targos authored Mar 31, 2022
commit a63982f305ed84a8094065f8e24021a589fef148
1 change: 1 addition & 0 deletions test/parallel/test-btoa-atob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ throws(() => buffer.atob(), /TypeError/);
throws(() => buffer.btoa(), /TypeError/);

strictEqual(atob(' '), '');
Comment thread
aduh95 marked this conversation as resolved.
strictEqual(atob(' YW\tJ\njZA=\r= '), 'abcd');