Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
04fc7e6
doc: add maintaining info for shared libary option
mhdawson Mar 29, 2022
d868979
fix typo
mhdawson Mar 29, 2022
31a712d
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
00f1f2b
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
e3d1085
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
e066018
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
2dea68b
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
b81291c
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
8f5935e
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
a5b3e46
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
c721355
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
b3c5a0a
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 30, 2022
4ce8d4a
squash: address comments
mhdawson Mar 30, 2022
6b136cd
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Mar 31, 2022
487a5c2
squash: address comments
mhdawson Mar 31, 2022
3f0212b
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Apr 7, 2022
5ca69c2
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Apr 7, 2022
1646f22
squash: address comments
mhdawson Apr 7, 2022
2136f11
squash: satisfy the linter
mhdawson Apr 7, 2022
b165ebd
Update doc/contributing/maintaining-shared-library-support.md
mhdawson Apr 21, 2022
86b1571
squash: address comments
mhdawson Apr 21, 2022
1912c7c
squash: address comments
mhdawson Apr 21, 2022
fa78950
Update doc/contributing/maintaining-shared-library-support.md
mhdawson May 10, 2022
7703b6e
squash: update to reflect current approach
mhdawson May 10, 2022
0a42b27
squash: address linter issues
mhdawson May 10, 2022
a89bafa
squash: stand on head to make linter happy
mhdawson May 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address linter issues
  • Loading branch information
mhdawson authored May 10, 2022
commit 0a42b27a1b637938e04f1062ea62b7264fb27fc5
6 changes: 3 additions & 3 deletions doc/contributing/maintaining-shared-library-support.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Node.js unofficially supports a build option where Node.js is built as
a shared library. The shared library is called libnode with additional postfixes
as appropriate for the platform (for example libnode.dll on windows).
as appropriate for the platform (for example libnode.dll on windows).
The shared library provides a way to embed Node.js into other
applications and to have multiple applications use a single copy of
Node.js instead of having to bundle in the full Node.js footprint
Expand Down Expand Up @@ -62,7 +62,7 @@ the following:
installed. This is where the default package that
is build with the shared library option will
place the executable and library.

For the node wrapper on windows it is built expecting
that both the executable and shared library will
be in the same directory as it common practice on
Expand All @@ -79,7 +79,7 @@ addons or additional Node.js executables need to have
NODE_EXTERN_PRIVATE or NODE_EXTERN otherwise they will
not be exported by the shared library. In the case of
functions used by additional Node.js executables
(ex: `mksnapshot`) a missing NODE_EXTERN or
(ex: `mksnapshot`) a missing NODE_EXTERN or
NODE_EXTERN_PRIVATE will cause the build to fail.
NODE_EXTERN_PRIVATE should be used in these cases
unless the intent is to add the function to the
Expand Down