Skip to content

[v12.x] Backport node-api finalization fixes #42512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 8 commits into from
Closed

[v12.x] Backport node-api finalization fixes #42512

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dfefe12
node-api: force env shutdown deferring behavior
Feb 10, 2021
7b6b7d3
node-api: stop ref gc during environment teardown
gabrielschulhof Mar 4, 2021
affb8b2
node-api: fix crash in finalization
mhdawson Mar 23, 2021
b4090b9
node-api: make reference weak parameter an indirect link to references
legendecas Mar 31, 2021
2a8bdd1
src: fix finalization crash
jasnell Apr 15, 2021
3939bba
node-api: fix shutdown crashes
mhdawson Apr 30, 2021
b9d99d7
node-api: avoid SecondPassCallback crash
mhdawson Jun 2, 2021
0fb5c42
node-api: cctest on v8impl::Reference
legendecas Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix finalization crash 
PR-URL: #38250
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@jasnell @legendecas
jasnell authored and legendecas committed Mar 29, 2022
commit 2a8bdd128dd4596df8154c46ec4e8e6755674050
4 changes: 4 additions & 0 deletions src/js_native_api_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ class Reference : public RefBase {

protected:
inline void Finalize(bool is_env_teardown = false) override {
if (is_env_teardown) env_teardown_finalize_started_ = true;
if (!is_env_teardown && env_teardown_finalize_started_) return;

// During env teardown, `~napi_env()` alone is responsible for finalizing.
// Thus, we don't want any stray gc passes to trigger a second call to
// `RefBase::Finalize()`. ClearWeak will ensure that even if the
Expand Down Expand Up @@ -467,6 +470,7 @@ class Reference : public RefBase {
reference->Finalize();
}

bool env_teardown_finalize_started_ = false;
v8impl::Persistent<v8::Value> _persistent;
SecondPassCallParameterRef* _secondPassParameter;
};
Expand Down