Skip to content

src: address 3 useless call coverity warnings #42426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 3 commits into from
Closed

src: address 3 useless call coverity warnings #42426

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31cef20
src: address 3 useless call coverity warnings
mhdawson Mar 21, 2022
ebf4f12
Update src/node_http2.cc
mhdawson Mar 22, 2022
a982aea
Update src/node_http2.cc
mhdawson Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: address 3 useless call coverity warnings 
Fix the last 3 useless call reports from coverity

Signed-off-by: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
@mhdawson
mhdawson committed Mar 21, 2022
commit 31cef2073887ef4c8090ac1f030139ff913b69b1
4 changes: 2 additions & 2 deletions src/inspector_js_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,10 @@ void InspectorConsoleCall(const FunctionCallbackInfo<Value>& info) {

Local<Value> node_method = info[1];
CHECK(node_method->IsFunction());
node_method.As<Function>()->Call(context,
USE(node_method.As<Function>()->Call(context,
info.Holder(),
call_args.length(),
call_args.out()).FromMaybe(Local<Value>());
call_args.out()));
}

static void* GetAsyncTask(int64_t asyncId) {
Expand Down
2 changes: 1 addition & 1 deletion src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2646,7 +2646,7 @@ void Http2Session::New(const FunctionCallbackInfo<Value>& args) {
static_cast<SessionType>(
args[0]->Int32Value(env->context()).ToChecked());
Http2Session* session = new Http2Session(state, args.This(), type);
session->get_async_id(); // avoid compiler warning
USE(session->get_async_id()); // avoid compiler warning
Comment thread
RaisinTen marked this conversation as resolved.
Outdated
Debug(session, "session created");
}

Expand Down
2 changes: 1 addition & 1 deletion src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,7 @@ void Parse(Environment* env,
null, // fragment defaults to null
};
SetArgs(env, argv, url);
cb->Call(context, recv, arraysize(argv), argv).FromMaybe(Local<Value>());
USE(cb->Call(context, recv, arraysize(argv), argv));
} else if (error_cb->IsFunction()) {
Local<Value> flags = Integer::NewFromUnsigned(isolate, url.flags);
USE(error_cb.As<Function>()->Call(context, recv, 1, &flags));
Expand Down