Skip to content

test: improve lib/internal/readline/promises.js coverage #42420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Apr 3, 2022
Merged

test: improve lib/internal/readline/promises.js coverage #42420

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee4cd15
test: improve lib/internal/readline/promises.js coverage
fossamagna Mar 21, 2022
2c52120
test: remove unnecessary await keyword
fossamagna Mar 22, 2022
19a968b
test: use destructuring assignment
fossamagna Mar 22, 2022
b215d31
test: make test more readable
fossamagna Mar 24, 2022
5c980e5
Apply suggestions from code review
fossamagna Mar 24, 2022
9630466
test: fix lint error
fossamagna Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: make test more readable 
using `await setImmediate` instead of `test` function + process.nextTick.
  • Loading branch information
@fossamagna
fossamagna committed Mar 24, 2022
commit b215d31968ba1ea8f25e2e2f3d9494559405e0d6
43 changes: 10 additions & 33 deletions test/parallel/test-readline-promises-csi.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import '../common/index.mjs';
import assert from 'assert';
import { Readline } from 'readline/promises';
import { setImmediate } from 'timers/promises';
import { Writable } from 'stream';

import utils from 'internal/readline/utils';
Expand Down Expand Up @@ -179,17 +180,9 @@ class TestWritable extends Writable {
[1, CSI.kClearToLineEnd],
[0, CSI.kClearLine],
]) {
const test = async (dir, data) => {
writable.data = '';
readline.clearLine(dir);
return new Promise((resolve) => {
process.nextTick(() => {
assert.deepStrictEqual(writable.data, data);
resolve();
});
});
};
await test(dir, data);
writable.data = '';
readline.clearLine(dir);
assert.deepStrictEqual((await setImmediate(writable)).data, data);
Comment thread
fossamagna marked this conversation as resolved.
Outdated
}
}

Expand All @@ -208,17 +201,9 @@ class TestWritable extends Writable {
[-1, -1, '\x1b[1D\x1b[1A'],
[1, -1, '\x1b[1C\x1b[1A'],
]) {
const test = async (x, y, data) => {
writable.data = '';
readline.moveCursor(x, y);
return new Promise((resolve) => {
process.nextTick(() => {
assert.strictEqual(writable.data, data);
resolve();
});
});
};
await test(x, y, data);
writable.data = '';
readline.moveCursor(x, y);
assert.deepStrictEqual((await setImmediate(writable)).data, data);
Comment thread
fossamagna marked this conversation as resolved.
Outdated
}
}

Expand All @@ -230,16 +215,8 @@ class TestWritable extends Writable {
[1, undefined, '\x1b[2G'],
[1, 2, '\x1b[3;2H'],
]) {
const test = async (x, y, data) => {
writable.data = '';
readline.cursorTo(x, y);
return new Promise((resolve) => {
process.nextTick(() => {
assert.strictEqual(writable.data, data);
resolve();
});
});
};
await test(x, y, data);
writable.data = '';
readline.cursorTo(x, y);
assert.deepStrictEqual((await setImmediate(writable)).data, data);
Comment thread
fossamagna marked this conversation as resolved.
Outdated
}
}