Skip to content

esm: make extension-less errors in type:module actionable #42301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Mar 15, 2022
Merged

esm: make extension-less errors in type:module actionable #42301

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afde82a
esm: make extension-less errors in type:module actionable
bmeck Mar 11, 2022
8cba2a8
fixup: linter
bmeck Mar 11, 2022
4718872
fixup: Update lib/internal/modules/esm/get_format.js
bmeck Mar 11, 2022
33af858
fixup: Update test/es-module/test-esm-unknown-or-no-extension.js
bmeck Mar 11, 2022
8a9b2b3
fixup: Update lib/internal/modules/esm/get_format.js
bmeck Mar 12, 2022
091e5a3
fixup: reviews and make suggestion copy paste friendly
bmeck Mar 12, 2022
5f5af00
Update lib/internal/modules/esm/get_format.js
bmeck Mar 14, 2022
efc80ce
Update lib/internal/modules/esm/get_format.js
bmeck Mar 14, 2022
57b980d
fixup: extensionless
bmeck Mar 14, 2022
6c334d7
fix rebase
bmeck Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/modules/esm/get_format.js 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
  • Loading branch information
@bmeck @ljharb
bmeck and ljharb committed Mar 14, 2022
commit efc80ce8eb4bae95cd3b2dfd65245918a167f1ec
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/get_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function getFileProtocolModuleFormat(url, context, ignoreErrors) {
const config = getPackageScopeConfig(url);
const fileBasename = basename(filepath);
const relativePath = StringPrototypeSlice(relative(config.pjsonPath, filepath), 1);
suggestion = 'Loading extension-less files is not supported inside of ' +
suggestion = 'Loading extensionless files is not supported inside of ' +
'"type":"module" package.json contexts. The package.json file ' +
`${config.pjsonPath} caused this "type":"module" context. Try ` +
`changing ${filepath} to have a file extension. Note the "bin" ` +
Expand Down