Skip to content

doc: make header smaller and dropdown click-driven when JS is on #42165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Mar 22, 2022
Merged

doc: make header smaller and dropdown click-driven when JS is on #42165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
770215f
doc: make header smaller and dropdown click-driven when JS is on
ShogunPanda Mar 1, 2022
e94673a
doc: add assets JS to the linting list
ShogunPanda Mar 2, 2022
3eae4bc
doc: refactored api script
ShogunPanda Mar 18, 2022
d785152
doc: defer script loading
ShogunPanda Mar 18, 2022
05c4fad
doc: defer script loading
ShogunPanda Mar 18, 2022
5e2d376
doc: ensure scope to api assets
ShogunPanda Mar 22, 2022
72a2aef
doc: linted code
ShogunPanda Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add assets JS to the linting list
  • Loading branch information
@ShogunPanda
ShogunPanda committed Mar 22, 2022
commit e94673a376d18ecd1780175a7736965b1b4ba057
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ tools/icu
tools/lint-md/lint-md.mjs
benchmark/tmp
doc/**/*.js
!doc/api_assets/*.js
!.eslintrc.js
16 changes: 8 additions & 8 deletions doc/api_assets/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
// Check if we have Javascript support

// Check if we have JavaScript support
document.querySelector(':root').classList.add('has-js');

// Restore user mode preferences
Expand Down Expand Up @@ -38,8 +38,8 @@ if (themeToggleButton) {

// Handle pickers with click/taps rather than hovers
const pickers = document.querySelectorAll('.picker-header');
for(const picker of pickers) {
picker.addEventListener('click', e => {
for (const picker of pickers) {
picker.addEventListener('click', (e) => {
if (!e.target.closest('.picker')) {
e.preventDefault();
}
Expand All @@ -57,17 +57,17 @@ for(const picker of pickers) {
}

// Track when the header is in sticky position
const header = document.querySelector(".header");
const header = document.querySelector('.header');
let ignoreNextIntersection = false;
new IntersectionObserver(
([e]) => {
const currentStatus = header.classList.contains('is-pinned');
const newStatus = e.intersectionRatio < 1;

// Same status, do nothing
if(currentStatus === newStatus) {
if (currentStatus === newStatus) {
return;
} else if(ignoreNextIntersection) {
} else if (ignoreNextIntersection) {
ignoreNextIntersection = false;
return;
}
Expand All @@ -84,4 +84,4 @@ new IntersectionObserver(
header.classList.toggle('is-pinned', newStatus);
},
{ threshold: [1] }
).observe(header);
).observe(header);