Skip to content

msi: enable CFG in node.exe #42126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msidhartha7 wants to merge 4 commits into from
+4 −0
Closed

msi: enable CFG in node.exe #42126

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bce0286
add changes to vcbuild.bat to enable CFG in node.exe
Feb 25, 2022
6ecbc5b
cdd changes to msbuild command
Feb 25, 2022
10b4d75
removed other flags
Feb 25, 2022
c41ce9c
add cl and linker options
Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed other flags
  • Loading branch information
Sidhartha committed Feb 25, 2022
commit 10b4d7562f7eb9495b6d011279ac09ce4919fe27
2 changes: 1 addition & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_ar
set UseMultiToolTask=True
set EnforceProcessCountAcrossBuilds=True
set MultiProcMaxCount=%NUMBER_OF_PROCESSORS%
msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args% /ZI- /clr- /guard:cf
msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args% /guard:cf
Comment thread
msidhartha7 marked this conversation as resolved.
Outdated
msbuild -help
if errorlevel 1 (
if not defined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen"
Expand Down