Skip to content

Capitalize Valgrind in docs #41986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 12 commits into from
Feb 15, 2022
Merged

Capitalize Valgrind in docs #41986

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1df6f7c
doc: capitalize valgrind
mahmoud-moursy Feb 15, 2022
1a06391
doc: fixed missing capitalization
mahmoud-moursy Feb 15, 2022
1e3825e
Update doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
5cfd4cb
Update doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
fe9627e
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
d03a93a
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
32cf332
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
df4304d
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
57d9bdb
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
813c878
fix lint at doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
d09ac1c
Thusly -> thus in doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
4fd894a
Update doc/contributing/investigating-native-memory-leaks.md
mahmoud-moursy Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Thusly -> thus in doc/contributing/investigating-native-memory-leaks.md 
Thanks @tniessen!

Co-authored-by: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
@mahmoud-moursy @tniessen
mahmoud-moursy and tniessen authored Feb 15, 2022
commit d09ac1c697d340daec32bb7be58b4816e00517ed
2 changes: 1 addition & 1 deletion doc/contributing/investigating-native-memory-leaks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,5 +451,5 @@ Running Valgrind using the debug build of Node.js shows:
Now we can see the specific file name and line in the Node.js code which
caused the allocation (inspector\_agent.cc:140).

Thusly, we can examine the line (and its surrounding code) in order
Thus, we can examine the line (and its surrounding code) in order
to find a potential solution for the memory leak.