Skip to content

src: add fetch to bootstrap/browser.js #41958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 2 commits into from
Closed

src: add fetch to bootstrap/browser.js #41958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ece79a
src: add fetch to bootstrap/browser.js
RaisinTen Feb 13, 2022
6f38000
fixup! src: add fetch to bootstrap/browser.js
RaisinTen Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: add fetch to bootstrap/browser.js 
Fixes: #41816
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Feb 13, 2022
commit 2ece79a64c13d3f8e1bb1e734d861c64adf4ca55
15 changes: 15 additions & 0 deletions lib/internal/bootstrap/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ const {

const {
defineOperation,
emitExperimentalWarning,
exposeInterface,
lazyDOMExceptionClass,
} = require('internal/util');

const { getOptionValue } = require('internal/options');

const config = internalBinding('config');

// Override global console from the one provided by the VM
Expand Down Expand Up @@ -71,6 +75,17 @@ defineOperation(globalThis, 'setTimeout', timers.setTimeout);
defineReplacableAttribute(globalThis, 'performance',
require('perf_hooks').performance);

// https://fetch.spec.whatwg.org/
if (getOptionValue('--experimental-fetch')) {
emitExperimentalWarning('Fetch');

const undici = require('internal/deps/undici/undici');
defineOperation(globalThis, 'fetch', undici.fetch);
exposeInterface(globalThis, 'Headers', undici.Headers);
exposeInterface(globalThis, 'Request', undici.Request);
exposeInterface(globalThis, 'Response', undici.Response);
}

function createGlobalConsole(consoleFromVM) {
const consoleFromNode =
require('internal/console/global');
Expand Down
1 change: 1 addition & 0 deletions src/node_external_reference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class ExternalReferenceRegistry {
V(messaging) \
V(native_module) \
V(os) \
V(options) \
V(performance) \
V(process_methods) \
V(process_object) \
Expand Down
6 changes: 6 additions & 0 deletions src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,6 +1128,11 @@ void Initialize(Local<Object> target,
.Check();
}

void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(GetCLIOptions);
registry->Register(GetEmbedderOptions);
}

} // namespace options_parser

void HandleEnvOptions(std::shared_ptr<EnvironmentOptions> env_options) {
Expand Down Expand Up @@ -1194,3 +1199,4 @@ std::vector<std::string> ParseNodeOptionsEnvVar(
} // namespace node

NODE_MODULE_CONTEXT_AWARE_INTERNAL(options, node::options_parser::Initialize)
NODE_MODULE_EXTERNAL_REFERENCE(options, node::options_parser::RegisterExternalReferences)