Skip to content

repl: #41690 REPL gives wrong autocomplete on literals #41883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Feb 10, 2022
Merged

repl: #41690 REPL gives wrong autocomplete on literals #41883

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07468f7
repl: #41690 REPL gives wrong autocomplete on literals
meixg Feb 7, 2022
38b1d2f
repl: #41690 REPL gives wrong autocomplete on literals
meixg Feb 8, 2022
903571d
repl: #41690 REPL gives wrong autocomplete on literals
meixg Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: #41690 REPL gives wrong autocomplete on literals 
add support to ``.at and ('').at

Fixes: #41690
  • Loading branch information
@meixg
meixg committed Feb 8, 2022
commit 38b1d2f128a5b6d3591df2e76dc67e8d7fe453fc
2 changes: 1 addition & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,7 @@ const importRE = /\bimport\s*\(\s*['"`](([\w@./:-]+\/)?(?:[\w@./:-]*))(?![^'"`])
const requireRE = /\brequire\s*\(\s*['"`](([\w@./:-]+\/)?(?:[\w@./:-]*))(?![^'"`])$/;
const fsAutoCompleteRE = /fs(?:\.promises)?\.\s*[a-z][a-zA-Z]+\(\s*["'](.*)/;
const simpleExpressionRE =
/(?:[\w$'"[{](?:\w|\$|['"\]}])*\??\.)*[a-zA-Z_$](?:\w|\$)*\??\.?$/;
/(?:[\w$'"`[{(](?:\w|\$|['"`\]})])*\??\.)*[a-zA-Z_$](?:\w|\$)*\??\.?$/;
const versionedFileNamesRe = /-\d+\.\d+/;

function isIdentifier(str) {
Expand Down