Skip to content

test: improve code coverage for streams/duplexify #41862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Feb 11, 2022
Merged

test: improve code coverage for streams/duplexify #41862

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d992bc7
test: improve code coverage for streams/duplexify
ErickWendel Feb 4, 2022
38c8b4e
test: make assertions on duplex.from instead of internal.duplexify
ErickWendel Feb 7, 2022
1530f06
test: add strictEqual for primitive values
ErickWendel Feb 8, 2022
3e3a3ed
test: add strictEqual to ensure objects references
ErickWendel Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add strictEqual to ensure objects references 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
  • Loading branch information
@ErickWendel
ErickWendel committed Feb 8, 2022
commit 3e3a3ed8d55658e6139cc7331c404b59635bcd5e
14 changes: 7 additions & 7 deletions test/parallel/test-stream-duplex-from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ const { Blob } = require('buffer');
// Ensure that isDuplexNodeStream was called
{
const duplex = new Duplex();
assert.deepStrictEqual(Duplex.from(duplex), duplex);
assert.strictEqual(Duplex.from(duplex), duplex);
}

// Ensure that Duplex.from works for blobs
Expand All @@ -167,7 +167,7 @@ const { Blob } = require('buffer');
const myErrorMessage = 'myCustomError';
Duplex.from(Promise.reject(myErrorMessage))
.on('error', common.mustCall((error) => {
assert.deepStrictEqual(error, myErrorMessage);
assert.strictEqual(error, myErrorMessage);
}));
}

Expand All @@ -180,7 +180,7 @@ const { Blob } = require('buffer');

Duplex.from(asyncFn)
.on('error', common.mustCall((error) => {
assert.deepStrictEqual(error, myErrorMessage);
assert.strictEqual(error, myErrorMessage);
}));
}

Expand All @@ -202,7 +202,7 @@ const { Blob } = require('buffer');
}
})
}).on('data', common.mustCall((data) => {
assert.deepStrictEqual(data, msg);
assert.strictEqual(data, msg);
}));

assert.strictEqual(duplex.writable, false);
Expand All @@ -214,7 +214,7 @@ const { Blob } = require('buffer');
const duplex = Duplex.from({
writable: Writable({
write: common.mustCall((data) => {
assert.deepStrictEqual(data, msg);
assert.strictEqual(data, msg);
})
})
});
Expand All @@ -236,14 +236,14 @@ const { Blob } = require('buffer');
}),
writable: Writable({
write: common.mustCall((data) => {
assert.deepStrictEqual(data, msg);
assert.strictEqual(data, msg);
})
})
});

duplex.pipe(duplex)
.on('data', common.mustCall((data) => {
assert.deepStrictEqual(data, msg);
assert.strictEqual(data, msg);
assert.strictEqual(duplex.readable, true);
assert.strictEqual(duplex.writable, true);
}))
Expand Down